-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move nf-core/demultiple test data from pipeline to test-datasets #920
Conversation
What happens when v1.4.0 releases? |
Is the samplesheet format unchanged since 1.0.0 ? |
We add a new folder for 1.4.0 if required. If not, we carry on using the 1.3.0 test data until we have to change it. This at least shows you the last version in which the test data was changed. |
I think that's misleading - the data version number will be different from the pipeline version number. |
Yes, they look unchanged according to commit history. |
Don't know of a more intelligent way to track test-data updates without making in-place changes that will break CI for older releases. Agree it's not perfect but it does the job, especially since test data isn't updated very frequently. Open to suggestions. |
Also, at the moment, the samplesheets for this pipeline were all over the place:
This unifies where to find all of the samplesheets in a single location. |
Then let's put in a |
Yeah it's definitely an improvement,
Yeah it's definitely an improvement. I would probably just go |
I guess that makes the most sense. |
Exactly. This way we know in which release it was last updated.
Nope, there are other samplesheets in this new folder that were changed/added more recently in later releases. Let's start with a blank slate with |
Closes nf-core/demultiplex#103